Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make extended tracer easier to use #6943

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

zeitlinger
Copy link
Member

No description provided.

@zeitlinger zeitlinger requested a review from a team as a code owner December 11, 2024 17:35
@zeitlinger zeitlinger self-assigned this Dec 11, 2024
Copy link

codecov bot commented Dec 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.10%. Comparing base (efdacc1) to head (d37d633).
Report is 7 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #6943      +/-   ##
============================================
+ Coverage     90.09%   90.10%   +0.01%     
  Complexity     6601     6601              
============================================
  Files           730      730              
  Lines         19843    19843              
  Branches       1955     1955              
============================================
+ Hits          17877    17879       +2     
+ Misses         1371     1370       -1     
+ Partials        595      594       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zeitlinger
Copy link
Member Author

@jack-berg please check

@trask
Copy link
Member

trask commented Dec 12, 2024

up to @jack-berg, but I'd suggest landing #6944 first without adding any new complications

@jkwatson
Copy link
Contributor

What do you think about adding a sample of usage in ExtendedTraceApiUsageTest ?

@zeitlinger
Copy link
Member Author

What do you think about adding a sample of usage in ExtendedTraceApiUsageTest ?

good idea - done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants